[dpdk-dev] [PATCH v2 4/4] testpmd: make use of per-PMD TxRx parameters
Thomas Monjalon
thomas at monjalon.net
Sat Mar 31 02:01:05 CEST 2018
21/03/2018 15:27, Remy Horton:
> /*
> * Configurable number of RX/TX ring descriptors.
Configurable, really?
> + * Defaults are supplied by drivers via ethdev.
And fallback values are in ethdev.
> */
> -#define RTE_TEST_RX_DESC_DEFAULT 1024
> -#define RTE_TEST_TX_DESC_DEFAULT 1024
> +#define RTE_TEST_RX_DESC_DEFAULT 0
> +#define RTE_TEST_TX_DESC_DEFAULT 0
We do not need a define for 0.
Better to rework a bit above and below comments.
> uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT; /**< Number of RX descriptors. */
> uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT; /**< Number of TX descriptors. */
These doxygen comments in the middle of the code are totally useless.
More information about the dev
mailing list