[dpdk-dev] [PATCH v2 2/2] mem: unmap unneeded space

Thomas Monjalon thomas at monjalon.net
Wed May 2 23:00:59 CEST 2018


30/04/2018 14:50, Bruce Richardson:
> On Mon, Apr 30, 2018 at 12:21:43PM +0100, Anatoly Burakov wrote:
> > When we ask to reserve virtual areas, we usually include
> > alignment in the mapping size, and that memory ends up
> > being wasted. Wasting a gigabyte of VA space while trying to
> > reserve one gigabyte is pretty expensive on 32-bit, so after
> > we're done mapping, unmap unneeded space.
> > 
> > Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
> > ---
> > 
> > Notes:
> >     v2:
> >     - Split fix for size_t overflow into separate patch
> >     - Improve readability of unmapping code
> >     - Added comment explaining why unmapping is done
> > 
> Acked-by: Bruce Richardson <bruce.richardson at intel.com>

I am not confident pushing this change post-rc1.
Please can we have more validation tests with this patch?





More information about the dev mailing list