[dpdk-dev] [PATCH 1/2] eal/malloc: merge malloc_elems in heap if they are contiguous

Burakov, Anatoly anatoly.burakov at intel.com
Fri May 4 11:29:57 CEST 2018


On 03-May-18 11:11 AM, Gowrishankar wrote:
> From: Gowrishankar Muthukrishnan <gowrishankar.m at linux.vnet.ibm.com>
> 
> During malloc heap init, if there are malloc_elems contiguous in
> virt addresses, they could be merged so that, merged malloc_elem
> would guarantee larger free memory size than its actual hugepage
> size, it was created for.
> 
> Fixes: fafcc11985 ("mem: rework memzone to be allocated by malloc")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m at linux.vnet.ibm.com>
> ---

Hi Gowrishankar,

I haven't looked at the patchset in detail yet, however i have a general 
question: how do we end up with VA-contiguous memsegs that are not part 
of the same memseg in the first place? Is there something wrong with 
memseg sorting code? Alternatively, if they were broken up, presumably 
they were broken up for a reason, namely while they may be VA 
contiguous, they weren't IOVA-contiguous.

Can you provide a dump of physmem layout where memory would have been VA 
and IOVA-contiguous while belonging to different memsegs?

-- 
Thanks,
Anatoly


More information about the dev mailing list