[dpdk-dev] [PATCH] eal: copy optarg when parsing mempool ops name

santosh santosh.shukla at caviumnetworks.com
Mon May 7 07:42:29 CEST 2018


On Friday 04 May 2018 04:01 PM, Andrew Rybchenko wrote:
> From: Ivan Malov <ivan.malov at oktetlabs.ru>
>
> The code aimed to pick and remember the value of
> mempool ops name from EAL command line arguments does not
> copy the string and remembers the pointer provided
> by getopt_long() directly. The latter could be clobbered
> later and result in reading wrong mbuf pool ops name
> by rte_mempool library.
>
> Typically, this flaw could be avoided by using strdup()
> to remember the string value of the option.
>
> Fixes: a103a97e7191 ("eal: allow user to override default mempool driver")
> Cc: Santosh Shukla <santosh.shukla at caviumnetworks.com>
> Cc: stable at dpdk.org
>
> Signed-off-by: Ivan Malov <ivan.malov at oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
> ---

Acked-by: Santosh Shukla <santosh.shukla at caviumnetworks.com>



More information about the dev mailing list