[dpdk-dev] [PATCH 12/18] drivers: net: sfc: fix another strncpy size and NUL

Andy Green andy at warmcat.com
Tue May 8 06:30:28 CEST 2018


---
 drivers/net/sfc/sfc_ethdev.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index e9bb283e0..bd5f17f33 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
@@ -662,10 +662,13 @@ sfc_xstats_get_names(struct rte_eth_dev *dev,
 
 	for (i = 0; i < EFX_MAC_NSTATS; ++i) {
 		if (EFX_MAC_STAT_SUPPORTED(port->mac_stats_mask, i)) {
-			if (xstats_names != NULL && nstats < xstats_count)
+			if (xstats_names != NULL && nstats < xstats_count) {
 				strncpy(xstats_names[nstats].name,
 					efx_mac_stat_name(sa->nic, i),
-					sizeof(xstats_names[0].name));
+					sizeof(xstats_names[0].name) - 1);
+				xstats_names[0].name[
+					sizeof(xstats_names[0].name) - 1] = '\0';
+			}
 			nstats++;
 		}
 	}



More information about the dev mailing list