[dpdk-dev] [PATCH v2] examples/ip_pipeline: fix buffer not null terminated.

[Dumitrescu, Cristian]

> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Tuesday, April 17, 2018 10:46 AM
> To: dev at dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu at intel.com>; Singh, Jasvinder
> <jasvinder.singh at intel.com>
> Subject: [PATCH v2] examples/ip_pipeline: fix buffer not null terminated.
> 
> Coverity issue: 272563
> Fixes: 8245472c58c8 ("examples/ip_pipeline: add sw queue object")
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang at intel.com>
> ---
> v2:
> - using more generic strlcpy approach
> 
>  examples/ip_pipeline/swq.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/examples/ip_pipeline/swq.c b/examples/ip_pipeline/swq.c
> index c11bbf27e..7e54a1dbf 100644
> --- a/examples/ip_pipeline/swq.c
> +++ b/examples/ip_pipeline/swq.c
> @@ -5,6 +5,8 @@
>  #include <stdlib.h>
>  #include <string.h>
> 
> +#include <rte_string_fns.h>
> +
>  #include "swq.h"
> 
>  static struct swq_list swq_list;
> @@ -64,7 +66,7 @@ swq_create(const char *name, struct swq_params
> *params)
>  	}
> 
>  	/* Node fill in */
> -	strncpy(swq->name, name, sizeof(swq->name));
> +	strlcpy(swq->name, name, sizeof(swq->name));
>  	swq->r = r;
> 
>  	/* Node add to list */
> --
> 2.13.6
Acked-by: Cristian.Dumitrescu <cristian.dumitrescu at intel.com>

Applied to next-pipeline tree, thanks!