[dpdk-dev] Please revert: [PATCH 2/2] net/mlx4: fix useless default in RSS converter
Ophir Munk
ophirmu at mellanox.com
Wed May 9 10:47:01 CEST 2018
Hi Shahaf, Adrien,
This commit (in next-net/master since 8-May-18) is breaking all testpmd calls with mlx4 NIC, see [1].
Can you please revert it?
[1]
PMD: net_mlx4: cannot set up internal flow rules (code 95, "Operation not supported"), flow error type 16, cause 0x7fffdb5bb3a0, message: unsupported RSS hash type requested
Fail to configure port 0
EAL: Error - exiting with code: 1
Cause: Start ports failed
> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Adrien Mazarguil
> Sent: Friday, May 04, 2018 6:18 PM
> To: Shahaf Shuler <shahafs at mellanox.com>
> Cc: Ferruh Yigit <ferruh.yigit at intel.com>; dev at dpdk.org; stable at dpdk.org
> Subject: [dpdk-dev] [PATCH 2/2] net/mlx4: fix useless default in RSS
> converter
>
> Since the commit below, mlx4_conv_rss_types() does not need to support
> special value -1 anymore. Other functions rely on priv->hw_rss_sup directly.
>
> Fixes: 1d173da83ef2 ("net/mlx4: fix default RSS hash fields")
> Cc: stable at dpdk.org
>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil at 6wind.com>
> ---
> drivers/net/mlx4/mlx4_flow.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c
> index 3f754b480..cb3b9a952 100644
> --- a/drivers/net/mlx4/mlx4_flow.c
> +++ b/drivers/net/mlx4/mlx4_flow.c
> @@ -78,9 +78,6 @@ struct mlx4_drop {
> /**
> * Convert DPDK RSS hash types to their Verbs equivalent.
> *
> - * This function returns the supported (default) set when @p types has
> - * special value (uint64_t)-1.
> - *
> * @param priv
> * Pointer to private structure.
> * @param types
> @@ -125,8 +122,6 @@ mlx4_conv_rss_types(struct priv *priv, uint64_t
> types)
> uint64_t conv = 0;
> unsigned int i;
>
> - if (types == (uint64_t)-1)
> - return priv->hw_rss_sup;
> for (i = 0; i != RTE_DIM(in); ++i)
> if (types & in[i]) {
> seen |= types & in[i];
> --
> 2.11.0
More information about the dev
mailing list