[dpdk-dev] [dpdk-stable] [PATCH v2] eventdev: make ethernet port identifiers 16 bit

Thomas Monjalon thomas at monjalon.net
Thu May 10 17:45:10 CEST 2018


10/05/2018 17:16, Jerin Jacob:
> From: Thomas Monjalon <thomas at monjalon.net>
> > 10/05/2018 16:30, Jerin Jacob:
> > > From: Thomas Monjalon <thomas at monjalon.net>
> > > > 10/05/2018 06:31, Jerin Jacob:
> > > > > > Date: Thu, 10 May 2018 02:22:40 +0530
> > > > > > From: Nikhil Rao <nikhil.rao at intel.com>
> > > > > > 
> > > > > > Ethernet port ID data size has been extended to 16 bits size 17.11
> > > > > > Update the Rx event adapter interface and implementation accordingly.
> > > > > > 
> > > > > > Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation")
> > > > > > Signed-off-by: Nikhil Rao <nikhil.rao at intel.com>
> > > > > > Cc: stable at dpdk.org
> > > > > 
> > > > > Since it is an ABI change, please bump the library version.
> > > > > eth_rx_adapter still under experimental tag, IMO, no deprecation notice is
> > > > > required.
> > > > 
> > > > The ABI changes must be described in the release notes too.
> > > > 
> > > > There is no deprecation notice for this ABI change.
> > > > According the the policy, you must send a notice in 18.05,
> > > > and do the change in 18.08.
> > > 
> > > Even for the APIs with experimental tag?
> > 
> > No, experimental can change without prior notice.
> > 
> > > If so, I don't see any
> > > difference between experimental vs non experimental API? 
> > 
> > Rx adapter is not experimental as far as I know.
> 
> It is experimental. Please see the links.
> 
> http://dpdk.org/browse/dpdk/tree/MAINTAINERS#n351
> http://dpdk.org/browse/dpdk/tree/lib/librte_eventdev/rte_event_eth_rx_adapter.h#n276

Yes, you're right.
I've looked at the map file, where the symbols are not in EXPERIMENTAL block.

> If you agree then take dropped patch.

I'll take it.




More information about the dev mailing list