[dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs

[Andy Green]

On 05/11/2018 08:29 AM, Andy Green wrote:
> 
> 
> On 05/10/2018 11:01 PM, Stephen Hemminger wrote:
>> On Thu, 10 May 2018 20:13:31 +0800
>> Andy Green <andy at warmcat.com> wrote:
>>
>>> I appreciate the reply.
>>>
>>> But why bother having a subject line at all if it is going to be
>>> mechanically enforced that nothing in it is allowed to be "useful"?
>>> That really doesn't make sense does it.
>>
>>
>> It was done because there were lots of clueless patches showing
>> up on the driver development list which had useless subject
>> lines.
> 
> The "cure" is worse than the disease...
> 
>   - I can mention, eg, that something changed to an int.  But a size_t 
> or my_type_t?  I am not allowed to mention it even if that is the whole 
> reason for the patch.
> 
>   - I can mention most libc apis, but not those that happen to have an 
> underscore, eg, timerfd_create(), even if that was the focus of the patch.
> 
>   - Any kind of manifest constant like MY_CONSTANT: illegal to mention, 
> even if the patch's job is change MY_CONSTANT to, say, 5.  What should I 
> entitle that patch?  "lib: change something to 5"?  "lib: change 
> MY.CONSTANT to 5"?
> 
>   - I can mention most filenames or paths, eg, down /proc, or myfile.c. 
> But not if the filepath happens to contain an underscore.  Even if the 
> effect of the patch is to migrate stuff from myfile.c to my_files/
> 
> The results are arbitrary... please consider removing this now it has 
> been in place a while and made its original point.

Having now used check-git-log.sh, also

1) It reports every patch has "Wrong headline uppercase" on Fedora 28, 
even, eg, "net/nfp: solve buffer overflow".  Googling around

https://stackoverflow.com/questions/11166825/grep-case-sensitive-a-z

I checked a patch on the patch checker to make it use [[:upper:]] and it 
works OK.  So there is another patch in the series adapting this.

2) It claims "app/test-pmd" is a "Wrong headline label". 
"app/proc-info" and "app/test-bbdev" are accepted.

It's because it does this, but app/test-pmd is a real directory:

# check headline label for common typos
bad=$(echo "$headlines" | grep --color=always \
         -e '^example[:/]' \
         -e '^apps/' \
         -e '^testpmd' \
         -e 'test-pmd' \
         -e '^bond:' \
         | sed 's,^,\t,')
[ -z "$bad" ] || printf "Wrong headline label:\n$bad\n"

I just left that and told it app:.

They all pass the thing now.

-Andy

> -Andy