[dpdk-dev] [PATCH v2 00/24] Fixes for GCC8 against lagopus

Stephen Hemminger stephen at networkplumber.org
Fri May 11 05:04:54 CEST 2018


On Fri, 11 May 2018 09:58:54 +0800
Andy Green <andy at warmcat.com> wrote:

> The following series fixes build problems in dpdk master
> headers, found when using it as the dpdk subproject in
> lagopus.  These errors are coming when you try to use
> the dpdk headers, not when you build dpdk itself.
> 
> Two patches are updated to follow requests for larger
> work.
> 
> ---
> 
> Andy Green (24):
>       lib/librte_eal: import libbsd strlcpy
>       lib/librte_ethdev: change eth-dev-ops API to return int
>       rte_common.h: cast gcc builtin result to avoid complaints
>       lib/librte_eal: explicit tmp cast
>       lib/librte_eal: explicit cast for signed change
>       /lib/librte_eal: stage cast from uint64 to long
>       rte_spinlock.h: stack declarations before code
>       rte_ring_generic.h: stack declarations before code
>       rte_ring.h: remove signed type flipflopping
>       rte_dev.h: stack declaration at top of own basic block
>       rte_mbuf.h: avoid warnings from inadvertant promotion
>       rte_mbuf.h: explicit casts for int16 to uint16
>       rte_mbuf.h: make sure RTE-MIN compares same types
>       rte_mbuf.h: explicit cast restricting ptrdiff to uint16
>       rte_mbuf.h: explicit cast for size type to uint32
>       rte_mbuf.h: explicit casts to uint16 to avoid warnings
>       rte_byteorder.h: explicit cast for return promotion
>       rte_ether.h: explicit cast avoiding truncation warning
>       rte_ether.h: stack vars declared at top of function
>       rte_ethdev.h: align sign and scope of temp var
>       rte_ethdev.h: explicit cast for truncation
>       rte_hash_crc.h: stack vars declared at top of function
>       rte_hash_crc.h: explicit casts for truncation
>       test_table_pipeline: repair munged indirection level
> 
> 
>  drivers/net/ark/ark_ethdev_rx.c                    |    4 +-
>  drivers/net/ark/ark_ethdev_rx.h                    |    3 +-
>  drivers/net/avf/avf_rxtx.c                         |    4 +-
>  drivers/net/avf/avf_rxtx.h                         |    2 +
>  drivers/net/bnxt/bnxt_ethdev.c                     |    5 ++-
>  drivers/net/dpaa/dpaa_ethdev.c                     |    4 +-
>  drivers/net/dpaa2/dpaa2_ethdev.c                   |    6 ++-
>  drivers/net/e1000/e1000_ethdev.h                   |    6 +--
>  drivers/net/e1000/em_rxtx.c                        |    4 +-
>  drivers/net/e1000/igb_rxtx.c                       |    4 +-
>  drivers/net/enic/enic_ethdev.c                     |    9 ++---
>  drivers/net/i40e/i40e_rxtx.c                       |    4 +-
>  drivers/net/i40e/i40e_rxtx.h                       |    3 +-
>  drivers/net/ixgbe/ixgbe_ethdev.h                   |    3 +-
>  drivers/net/ixgbe/ixgbe_rxtx.c                     |    4 +-
>  drivers/net/nfp/nfp_net.c                          |    9 ++---
>  drivers/net/sfc/sfc_ethdev.c                       |    4 +-
>  drivers/net/thunderx/nicvf_ethdev.c                |    2 +
>  drivers/net/thunderx/nicvf_rxtx.c                  |    4 +-
>  drivers/net/thunderx/nicvf_rxtx.h                  |    2 +
>  drivers/net/vhost/rte_eth_vhost.c                  |    4 +-
>  examples/l3fwd-power/main.c                        |    2 +
>  lib/librte_eal/common/eal_common_string_fns.c      |   34 +++++++++++++++++++
>  .../common/include/arch/x86/rte_memcpy.h           |    8 ++--
>  .../common/include/arch/x86/rte_spinlock.h         |    4 ++
>  .../common/include/generic/rte_byteorder.h         |    2 +
>  lib/librte_eal/common/include/rte_common.h         |    2 +
>  lib/librte_eal/common/include/rte_dev.h            |   15 +++++---
>  lib/librte_eal/common/include/rte_lcore.h          |    2 +
>  lib/librte_eal/common/include/rte_random.h         |    6 ++-
>  lib/librte_eal/common/include/rte_string_fns.h     |    7 +---
>  lib/librte_ethdev/rte_ethdev.h                     |   30 ++++++++++-------
>  lib/librte_ethdev/rte_ethdev_core.h                |    4 +-
>  lib/librte_hash/rte_hash_crc.h                     |   11 +++---
>  lib/librte_mbuf/rte_mbuf.h                         |   36 +++++++++++---------
>  lib/librte_net/rte_ether.h                         |    5 ++-
>  lib/librte_ring/rte_ring.h                         |    4 +-
>  lib/librte_ring/rte_ring_c11_mem.h                 |    2 +
>  lib/librte_ring/rte_ring_generic.h                 |   10 ++----
>  test/test/test_table_pipeline.c                    |    4 +-
>  40 files changed, 157 insertions(+), 121 deletions(-)
> 
> --
> Signature

All looks good to me.

Reviewed-by: Stephen Hemminger <stephen at networkplumber.org>


More information about the dev mailing list