[dpdk-dev] [PATCH v6 14/16] app/proc-info: sprintf overrun bug
Ferruh Yigit
ferruh.yigit at intel.com
Mon May 14 22:31:49 CEST 2018
On 5/14/2018 6:01 AM, Andy Green wrote:
> /home/agreen/projects/dpdk/app/proc-info/main.c: In function
> ‘nic_xstats_display’:
> /home/agreen/projects/dpdk/app/proc-info/main.c:495:45:
> error: ‘%s’ directive writing up to 255 bytes into a region
> of size between 165 and 232 [-Werror=format-overflow=]
> sprintf(buf, "PUTVAL %s/dpdkstat-port.%u/%s-%s N:%"
> ^~
> PRIu64"\n", host_id, port_id, counter_type,
> ~~~~~~~~~~~~
> /home/agreen/projects/dpdk/app/proc-info/main.c:495:4: note:
> ‘sprintf’ output between 31 and 435 bytes into a destination
> of size 256
> sprintf(buf, "PUTVAL %s/dpdkstat-port.%u/%s-%s N:%"
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> PRIu64"\n", host_id, port_id, counter_type,
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> xstats_names[i].name, values[i]);
>
> Signed-off-by: Andy Green <andy at warmcat.com>
> Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id")
> Cc: stable at dpdk.org
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
More information about the dev
mailing list