[dpdk-dev] [PATCH] net/tap: fix the vdev data sharing for tun

Varghese, Vipin vipin.varghese at intel.com
Tue May 15 14:56:11 CEST 2018


HI Keith,

Thanks for the input, please find my answer inline to email therad

<Snipped>

> > +		/* TODO: request info from primary to set up Rx and Tx */
> 
> What is the rule (if we have one) about having TODO, FIXME, … like comments in
> the code? Maybe remove the todo and create a enhancement request for later.
> 

I am not aware of the 'To Do' planned. This came in as part of logic block from previous commit for all PMD to support Secondary

<Snipped> 

> 
> Regards,
> Keith



More information about the dev mailing list