[dpdk-dev] [PATCH] eal: move runtime dir creation after args parse

Thomas Monjalon thomas at monjalon.net
Tue May 15 16:03:01 CEST 2018


15/05/2018 14:16, Burakov, Anatoly:
> On 15-May-18 12:36 PM, Andrew Rybchenko wrote:
> > On 05/15/2018 01:44 PM, Anatoly Burakov wrote:
> >> The intention of the original code was to create runtime data
> >> directory as early as possible, however it was moved too early,
> >> before the arguments were parsed, resulting in --file-prefix
> >> option essentially not working.
> >>
> >> Fix this by moving eal_create_runtime_dir() to after command
> >> line arguments parsing.
> >>
> >> Fixes: 56236363b481 ("eal: add directory for runtime data")
> >>
> >> Reported-by: Andrew Rybchenko <arybchenko at solarflare.com>
> >>
> >> Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
> > 
> > Tested-by: Andrew Rybchenko <arybchenko at solarflare.com>
> > 
> > I've tested it quickly and it solves the problem I observe.
> > I suppose it is OK that the directory remains after application exit.
> > 
> 
> Previously, all of the files that we were creating during runtime 
> remained, so having a directory where all the files are is better than 
> having a scattering of files :)
> 
> Thanks for testing!

Applied, thanks




More information about the dev mailing list