[dpdk-dev] [PATCH v3 2/4] net/bnx2x: correct unmeetable comparison

Thomas Monjalon thomas at monjalon.net
Tue May 15 16:46:05 CEST 2018


15/05/2018 00:16, Mody, Rasesh:
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Andy Green
> > Sent: Sunday, May 13, 2018 10:05 PM
> > 
> > /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c:
> > In function ‘elink_check_kr2_wa’:
> > /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c:12922:28:
> > error: bitwise comparison always evaluates to false [-Werror=tautological-
> > compare]
> >         ((next_page & 0xe0) == 0x2))));
> > 
> > This was fixed elsewhere in 2014
> > 
> > Signed-off-by: Andy Green <andy at warmcat.com>
> > Fixes: b5bf7719221d ("bnx2x: driver support routines")
> > Cc: stable at dpdk.org
> > ---
> 
> Acked-by: Rasesh Mody <rasesh.mody at cavium.com>

I would appreciate a review of the 2 other bnx2x patches in this series, please.




More information about the dev mailing list