[dpdk-dev] [PATCH] log: fix pattern matching

Ferruh Yigit ferruh.yigit at intel.com
Wed May 16 16:05:23 CEST 2018


loglevel set wrong when ":" is used as seperator, like
--log-type="user:debug"

This is because fnmatch returns zero on success. Fixed fnmatch return
value check.

Fixes: 7f0bb634a140 ("log: add ability to match log type with globbing")
Cc: stephen at networkplumber.org

Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 lib/librte_eal/common/eal_common_log.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
index c660ca659..818118944 100644
--- a/lib/librte_eal/common/eal_common_log.c
+++ b/lib/librte_eal/common/eal_common_log.c
@@ -184,7 +184,7 @@ rte_log_set_level_pattern(const char *pattern, uint32_t level)
 		if (rte_logs.dynamic_types[i].name == NULL)
 			continue;
 
-		if (fnmatch(pattern, rte_logs.dynamic_types[i].name, 0))
+		if (fnmatch(pattern, rte_logs.dynamic_types[i].name, 0) == 0)
 			rte_logs.dynamic_types[i].loglevel = level;
 	}
 
-- 
2.14.3



More information about the dev mailing list