[dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API

[Maxime Coquelin]

On 05/22/2018 02:09 PM, Tiwei Bie wrote:
> On Tue, May 22, 2018 at 07:53:57PM +0800, Tiwei Bie wrote:
>> On Tue, May 22, 2018 at 01:36:39PM +0200, Maxime Coquelin wrote:
>>> Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
>>> ---
>>>   drivers/net/vhost/rte_eth_vhost.c | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
>>> index f473bbbb3..aadb2327c 100644
>>> --- a/drivers/net/vhost/rte_eth_vhost.c
>>> +++ b/drivers/net/vhost/rte_eth_vhost.c
>>> @@ -491,9 +491,9 @@ eth_dev_configure(struct rte_eth_dev *dev __rte_unused)
>>>   	struct pmd_internal *internal = dev->data->dev_private;
>>>   	const struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;
>>>   
>>> -	internal->vlan_strip = rxmode->hw_vlan_strip;
>>> +	internal->vlan_strip = !!(rxmode->offloads & DEV_RX_OFFLOAD_VLAN_STRIP);
>>>   
>>> -	if (rxmode->hw_vlan_filter)
>>> +	if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_FILTER)
>>>   		VHOST_LOG(WARNING,
>>>   			"vhost(%s): vlan filtering not available\n",
>>>   			internal->dev_name);
>>
>> To better align with the new offload API, I think we
>> also need to announce those features in dev_infos_get.

I'm looking at it, and agree we have to announce support for these
offload features.

> I mean offloads (I'm too used to say features recently...).
> Besides, maybe we can also take this chance to announce the
> DEV_TX_OFFLOAD_MULTI_SEGS offload. How do you think?

Yes, and also DEV_TX_OFFLOAD_VLANiINSERT. Right?

> Best regards,
> Tiwei Bie
>