[dpdk-dev] [PATCH v4] net/tap: perform proto field update for tun only

Wiles, Keith keith.wiles at intel.com
Wed May 23 06:48:47 CEST 2018



> On May 22, 2018, at 11:44 PM, Varghese, Vipin <vipin.varghese at intel.com> wrote:
> 
> The TX function is shared between TAP and TUN PMD. Checking TUN-TAP
> type field will ensure the TAP PMD will always have protocol field
> as 0.
> 
> Signed-off-by: Vipin Varghese <vipin.varghese at intel.com>
> Suggested-by: Ferruh Yigit <ferruh.yigit at intel.com>
> ---
> Changes in V4:
> - convert comparision with MACRO - Keith Wiles
> - add LOG err for tun using set MAC - Ophir Munk
> 
> Changes in V3:
> - remove type field from rx struct - Ophir Munk
> - add space for comment in struct - Ophir Munk
> - pass type field into eth_dev_tap_create - Ophir Munk
> - replace with enum value for type - Ophir Munk
> - return as 'not supported' for mac_set - Vipin Varghese
> 
> Changes in V2:
> - updated in comment wording - Keith Wiles
> - remove debug print from tx code - Keith Wiles
>
Looks good to me.

Acked-by: Keith Wiles<keith.wiles at intel.com>

Regards,
Keith



More information about the dev mailing list