[dpdk-dev] [PATCH] compress/qat: fix out-of-bounds error

Bruce Richardson bruce.richardson at intel.com
Thu Nov 1 15:16:51 CET 2018


On Wed, Oct 31, 2018 at 06:35:11AM +0000, Jerin Jacob wrote:
> -----Original Message-----
> > Date: Wed, 31 Oct 2018 00:39:54 +0000
> > From: Fiona Trahe <fiona.trahe at intel.com>
> > To: dev at dpdk.org
> > CC: thomas at monjalon.net, akhil.goyal at nxp.com, tomaszx.jozwiak at intel.com,
> >  jerin.jacob at caviumnetworks.com, Fiona Trahe <fiona.trahe at intel.com>
> > Subject: [PATCH] compress/qat: fix out-of-bounds error
> > X-Mailer: git-send-email 1.7.0.7
> > 
> > 
> > QAT array for sgls in intermediate buffer structure
> > was #defined to 1, but setup code hardcoded as if 2 buffers
> > so causing out of bounds write. Reworked to loop correctly
> > using #define.
> > 
> > Fixes: a124830a6f00 ("compress/qat: enable dynamic huffman encoding")
> > 
> > Reported-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>
> > Signed-off-by: Fiona Trahe <fiona.trahe at intel.com>
> 
> clang build is not reproducible with this patch.

s/not/now/ :-)
> 
> Tested-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>
> 

I can also confirm that clang builds which were failing without this patch
are now building ok on Fedora 29.

Acked-by: Bruce Richardson <bruce.richardson at intel.com>



More information about the dev mailing list