[dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

Varghese, Vipin vipin.varghese at intel.com
Mon Nov 26 10:46:46 CET 2018


Hi Konstantin,

> >
> > If the operator is '|' what else except of 'OR' you expect it to be remapped?

Thanks for your correction. I have rerun with logical or 

                        if ((ret) || (!is_leaf))
   9a512:       83 bd 3c fd ff ff 00    cmp    DWORD PTR [rbp-0x2c4],0x0
   9a519:       75 7e                   jne    9a599 <show_tm+0x739>
   9a51b:       8b 85 28 fd ff ff       mov    eax,DWORD PTR [rbp-0x2d8]
   9a521:       85 c0                   test   eax,eax
   9a523:       74 74                   je     9a599 <show_tm+0x739>
                                continue;

There is no conversion to 'Or' operation here. Thanks for 

> BTW, I am agree with Reshma it has to be '||' here.
Thanks for your opinion, can you share review comments for show_tm for debug?

Thanks
Vipin Varghese


More information about the dev mailing list