[dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload support

Ferruh Yigit ferruh.yigit at intel.com
Mon Oct 1 18:11:50 CEST 2018

On 10/1/2018 4:59 PM, Jerin Jacob wrote:
> -----Original Message-----
>> Date: Mon, 1 Oct 2018 14:46:39 +0100
>> From: Ferruh Yigit <ferruh.yigit at intel.com>
>> To: Jerin Jacob <jerin.jacob at caviumnetworks.com>, Wenzhuo Lu
>>  <wenzhuo.lu at intel.com>, Jingjing Wu <jingjing.wu at intel.com>, Bernard
>>  Iremonger <bernard.iremonger at intel.com>, John McNamara
>>  <john.mcnamara at intel.com>, Marko Kovacevic <marko.kovacevic at intel.com>,
>>  Thomas Monjalon <thomas at monjalon.net>, Andrew Rybchenko
>>  <arybchenko at solarflare.com>
>> CC: dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload
>>  support
>> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
>>  Thunderbird/52.9.1
>> On 9/13/2018 2:47 PM, Jerin Jacob wrote:
>>> Signed-off-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>
>> Overall set looks good to me, I put some comments on individual patches.
>> And can you please rebase on top of latest head?
> Sure.
> Regarding space issue mentioned in other email in this thread.
> It looks like similar space added in other offloads.
> example: http://git.dpdk.org/dpdk/tree/app/test-pmd/config.c#n571

Hi Jerin,

This is just detail, the alignment is broken in the output of the log, for
others on/off start from column 56, for this one it is 57, just delete a space
from printf please.

> So, I expect no change in this patch other than rebase to latest head.
> If not, let me know.
>> Thanks,
>> ferruh

More information about the dev mailing list