[dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload support
ferruh.yigit at intel.com
Tue Oct 2 11:13:29 CEST 2018
On 10/1/2018 4:59 PM, Jerin Jacob wrote:
> -----Original Message-----
>> Date: Mon, 1 Oct 2018 14:46:39 +0100
>> From: Ferruh Yigit <ferruh.yigit at intel.com>
>> To: Jerin Jacob <jerin.jacob at caviumnetworks.com>, Wenzhuo Lu
>> <wenzhuo.lu at intel.com>, Jingjing Wu <jingjing.wu at intel.com>, Bernard
>> Iremonger <bernard.iremonger at intel.com>, John McNamara
>> <john.mcnamara at intel.com>, Marko Kovacevic <marko.kovacevic at intel.com>,
>> Thomas Monjalon <thomas at monjalon.net>, Andrew Rybchenko
>> <arybchenko at solarflare.com>
>> CC: dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload
>> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
>> On 9/13/2018 2:47 PM, Jerin Jacob wrote:
>>> Signed-off-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>
>> Overall set looks good to me, I put some comments on individual patches.
>> And can you please rebase on top of latest head?
> Regarding space issue mentioned in other email in this thread.
> It looks like similar space added in other offloads.
> example: http://git.dpdk.org/dpdk/tree/app/test-pmd/config.c#n571
> So, I expect no change in this patch other than rebase to latest head.
> If not, let me know.
As commented to the patch, can you also check "csum show", "csum set" functions
in testpmd, I think they are affected and need to be updated with your patch.
More information about the dev