[dpdk-dev] [PATCH v5 01/19] vhost: fix messages results handling

Maxime Coquelin maxime.coquelin at redhat.com
Thu Oct 11 11:36:26 CEST 2018



On 10/11/2018 11:32 AM, Ilya Maximets wrote:
> On 10.10.2018 10:25, Maxime Coquelin wrote:
>> Hi Ilya
>>
>> On 10/09/2018 10:54 PM, Maxime Coquelin wrote:
>>> Return of message handling has now changed to an enum that can
>>> take non-negative value that is not zero in case a reply is
>>> needed. But the code checking the variable afterwards has not
>>> been updated, leading to success messages handling being
>>> treated as errors.
>>>
>>> External post and pre callbacks return type needs also to be
>>> changed to the new enum, so that its handling is consistent.
>>> This is done in this patch alongside with the convertion of
>>> its only user, vhost-crypto backend.
>>>
>>> Fixes: 0bff510b5ea6 ("vhost: unify message handling function signature")
>>>
>>> Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
>>> Acked-by: Ilya Maximets <i.maximets at samsung.com>
>>
>> Sorry, I just notice I forgot to remove your ack from the commit
>> message as it has quite changed since the previous version.
>>
>> Please let me know if the patch is OK to you.
> 
> Hi. Sorry for delay.
> Had no time to check it yesterday.
> Will take a look at your new v6.

No worries, I really appreciate the detailed review you've done so far.

Thanks,
Maxime
> Best regards, Ilya Maximets.
> 
>>
>> Regards,
>> Maxime


More information about the dev mailing list