[dpdk-dev] [PATCH v6 2/2] net/virtio: fix PCI config err handling
thomas at monjalon.net
Thu Oct 11 12:27:57 CEST 2018
28/08/2018 12:12, Luca Boccassi:
> From: Brian Russell <brussell at brocade.com>
> In virtio_read_caps and vtpci_msix_detect, rte_pci_read_config returns
> the number of bytes read from PCI config or < 0 on error.
> If less than the expected number of bytes are read then log the
> failure and return rather than carrying on with garbage.
> Fixes: 6ba1f63b5ab0 ("virtio: support specification 1.0")
> Signed-off-by: Brian Russell <brussell at brocade.com>
> Signed-off-by: Luca Boccassi <bluca at debian.org>
> v2: handle additional rte_pci_read_config incomplete reads
> v3: do not handle rte_pci_read_config of virtio cap, added in v2,
> as it's less clear what the right thing to do there is
> v4: do a more robust check - first check what the vendor is, and
> skip the cap entirely if it's not what we are looking for.
> v5: fetch only 2 flags bytes if the vndr is PCI_CAP_ID_MSIX
> v6: fix 32bit build by changing the printf format specifier, fix patch title
Tiwei did a comment on v5 and provided his Reviewed-by.
Is it OK to apply v6 with its tag?
All is fixed?
More information about the dev