[dpdk-dev] [PATCH v4 3/3] app/testpmd: set packet dump based on verbosity level
bernard.iremonger at intel.com
Thu Oct 11 17:24:35 CEST 2018
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Thursday, October 11, 2018 4:00 PM
> To: Raslan Darawsheh <rasland at mellanox.com>; Wu, Jingjing
> <jingjing.wu at intel.com>
> Cc: Thomas Monjalon <thomas at monjalon.net>; dev at dpdk.org; Shahaf Shuler
> <shahafs at mellanox.com>; Xueming(Steven) Li <xuemingl at mellanox.com>; Ori
> Kam <orika at mellanox.com>; jerin.jacob at caviumnetworks.com;
> david.marchand at 6wind.com; Iremonger, Bernard
> <bernard.iremonger at intel.com>
> Subject: Re: [dpdk-dev] [PATCH v4 3/3] app/testpmd: set packet dump based on
> verbosity level
> On 10/7/2018 8:38 AM, Raslan Darawsheh wrote:
> > when changing verbosity level it will configure rx/tx callbacks to
> > dump packets based on the verbosity value as following:
> > 1- dump only received packets:
> > testpmd> set verbose 1
> > 2- dump only sent packets:
> > testpmd> set verbose 2
> > 3- dump sent and received packets:
> > testpmd> set verbose (any number > 2)
> > 4- disable dump
> > testpmd> set verbose 0
> It is good to able to enable Rx/Tx separately but you are overloading "verbose"
> meaning here. "verbose" is kind of log_level internal to testpmd and can be used
> by many testpmd debug log.
> Why not create a separate setting for it, perhaps like pkt_verbose?
The original code in rxonly.c used the verbose level, I don't think it is good idea to add a new pkt_verbose.
Users will be expecting it to work as before.
More information about the dev