[dpdk-dev] [PATCH v4 04/13] telemetry: add initial connection socket

Van Haaren, Harry harry.van.haaren at intel.com
Tue Oct 16 02:45:37 CEST 2018

> -----Original Message-----
> From: Laatz, Kevin
> Sent: Thursday, October 11, 2018 9:58 AM
> To: dev at dpdk.org
> Cc: Van Haaren, Harry <harry.van.haaren at intel.com>;
> stephen at networkplumber.org; gaetan.rivet at 6wind.com; shreyansh.jain at nxp.com;
> thomas at monjalon.net; mattias.ronnblom at ericsson.com; Richardson, Bruce
> <bruce.richardson at intel.com>; Ciara Power <ciara.power at intel.com>; Brian
> Archbold <brian.archbold at intel.com>; Laatz, Kevin <kevin.laatz at intel.com>
> Subject: [PATCH v4 04/13] telemetry: add initial connection socket
> From: Ciara Power <ciara.power at intel.com>
> This patch adds the telemetry UNIX socket. It is used to
> allow connections from external clients.
> On the initial connection from a client, ethdev stats are
> registered in the metrics library, to allow for their retrieval
> at a later stage.
> Signed-off-by: Ciara Power <ciara.power at intel.com>
> Signed-off-by: Brian Archbold <brian.archbold at intel.com>
> Signed-off-by: Kevin Laatz <kevin.laatz at intel.com>
> ---

<big snip>

> +static int32_t
> +rte_telemetry_create_socket(struct telemetry_impl *telemetry)
> +{
> +	int ret;
> +	struct sockaddr_un addr = {0};
> +	char socket_path[BUF_SIZE];

BUF_SIZE is not yet defined - it is in the next patch.
Pull the #define back into this patchset; now this patch
(without next one applied) won't build. With that fix;

Acked-by: Harry van Haaren <harry.van.haaren at intel.com>

More information about the dev mailing list