[dpdk-dev] [PATCH v4 2/3] app/testpmd: add packet dump callback functions

[Raslan Darawsheh]

Hi Ferruh,

This is a good point I'll fix it and send a new version for it. 

Kindest regards,
Raslan Darawsheh

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit at intel.com>
> Sent: Thursday, October 11, 2018 5:58 PM
> To: Raslan Darawsheh <rasland at mellanox.com>; jingjing.wu at intel.com
> Cc: Thomas Monjalon <thomas at monjalon.net>; dev at dpdk.org; Shahaf
> Shuler <shahafs at mellanox.com>; Xueming(Steven) Li
> <xuemingl at mellanox.com>; Ori Kam <orika at mellanox.com>;
> jerin.jacob at caviumnetworks.com; david.marchand at 6wind.com;
> bernard.iremonger at intel.com
> Subject: Re: [dpdk-dev] [PATCH v4 2/3] app/testpmd: add packet dump
> callback functions
> 
> On 10/7/2018 8:38 AM, Raslan Darawsheh wrote:
> > add new rx/tx callback functions to be used for dumping the packets.
> >
> > Signed-off-by: Raslan Darawsheh <rasland at mellanox.com>
> 
> <...>
> 
> > +uint16_t
> > +dump_rx_pkts(uint16_t port_id, uint16_t queue, struct rte_mbuf *pkts[],
> > +	     uint16_t nb_pkts, __rte_unused uint16_t max_pkts,
> > +	     __rte_unused void *user_param)
> > +{
> > +	dump_pkt_burst(port_id, queue, pkts, nb_pkts, 1);
> 
> You can add an enum or define to clarify what last param 0/1 is.
> 
> > +	return nb_pkts;
> > +}
> > +
> > +uint16_t
> > +dump_tx_pkts(uint16_t port_id, uint16_t queue, struct rte_mbuf *pkts[],
> > +	     uint16_t nb_pkts, __rte_unused void *user_param) {
> > +	dump_pkt_burst(port_id, queue, pkts, nb_pkts, 0);
> > +	return nb_pkts;
> > +}
> >