[dpdk-dev] [PATCH v3 2/6] net/mlx5: flow counters new configuration flags

[Shahaf Shuler]

Friday, October 19, 2018 6:21 PM, Slava Ovsiienko:
> Subject: [PATCH v3 2/6] net/mlx5: flow counters new configuration flags

How about "net/mlx5: rename flow counter configuration macro" ?

> 
> In this part of patchset some modifications in compile configuration flags are
> done. 

Ditto. 

The HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT is replaced with
> HAVE_IBV_DEVICE_COUNTERS_SET_V42. At this stage it is just flag
> renaming. 

Up till here great. You can also add it is a preparation to the new counter support were we will have 2 different configuration macros for the counters. 
The patch should only rename the existing macro. The subsequent patch should add the new macro for the new counter support along with the implementation. 
The below part should be on the commit log of that patch. 

The new HAVE_IBV_DEVICE_COUNTERS_SET_V45 flag is
> introduced. Both makefile and meson.build are changed, the flag
> modifications are grouped, no more build system files modifications are
> expected in this patchset, ones are grouped in this part.
> HAVE_IBV_DEVICE_COUNTERS_SET_V45 is just introduced, no code
> dependence in this part of pathset.
> 
> HAVE_IBV_DEVICE_COUNTERS_SET_V42 - is defined if system supports the
> "old" flow counters functionality, MLNX_OFED version from
> 4.2 to 4.4 is required.
> 
> HAVE_IBV_DEVICE_COUNTERS_SET_V45 - is defined if system supports the
> "new" flow counters functionality, MLNX_OVED 4.5 (or higher) or Linux
> rdma-core v19 (or higher) is required.
> 
> Neither HAVE_IBV_DEVICE_COUNTERS_SET_V42 not
> HAVE_IBV_DEVICE_COUNTERS_SET_V45 is defined if there is no counters
> support.
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo at mellanox.com>
> ---
>  drivers/net/mlx5/Makefile          |  9 +++++++--
>  drivers/net/mlx5/meson.build       |  6 ++++--
>  drivers/net/mlx5/mlx5.c            |  4 ++--
>  drivers/net/mlx5/mlx5_flow_verbs.c | 10 +++++-----
>  drivers/net/mlx5/mlx5_glue.c       |  8 ++++----
>  drivers/net/mlx5/mlx5_glue.h       |  2 +-
>  6 files changed, 23 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile index
> 1e9c0b4..28547d3 100644
> --- a/drivers/net/mlx5/Makefile
> +++ b/drivers/net/mlx5/Makefile
> @@ -157,9 +157,14 @@ mlx5_autoconf.h.new: $(RTE_SDK)/buildtools/auto-
> config-h.sh
>  		enum ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT \
>  		$(AUTOCONF_OUTPUT)
>  	$Q sh -- '$<' '$@' \
> -		HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT \
> +		HAVE_IBV_DEVICE_COUNTERS_SET_V42 \

>From this line

> + 		infiniband/verbs.h \
> + 		type 'struct ibv_counter_set_init_attr' \
> + 		$(AUTOCONF_OUTPUT)

Till this one you have an extra space at the start of the line. Need to have all indentation with tabs. 

> +	$Q sh -- '$<' '$@' \
> +		HAVE_IBV_DEVICE_COUNTERS_SET_V45 \
>  		infiniband/verbs.h \
> -		type 'struct ibv_counter_set_init_attr' \
> +		type 'struct ibv_counters_init_attr' \
>  		$(AUTOCONF_OUTPUT)
>  	$Q sh -- '$<' '$@' \
>  		HAVE_RDMA_NL_NLDEV \
> diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build
> index c192d44..1c4ed30 100644
> --- a/drivers/net/mlx5/meson.build
> +++ b/drivers/net/mlx5/meson.build
> @@ -79,8 +79,10 @@ if build
>  	has_member_args = [
>  		[ 'HAVE_IBV_MLX5_MOD_SWP', 'infiniband/mlx5dv.h',
>  		'struct mlx5dv_sw_parsing_caps', 'sw_parsing_offloads' ],
> -		[ 'HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT',
> 'infiniband/verbs.h',
> -		'struct ibv_counter_set_init_attr', 'counter_set_id' ],
> +		[ 'HAVE_IBV_DEVICE_COUNTERS_SET_V42',
> 'infiniband/verbs.h',
> + 		'struct ibv_counter_set_init_attr', 'counter_set_id' ],

Same about the extra space. 

> +		[ 'HAVE_IBV_DEVICE_COUNTERS_SET_V45',
> 'infiniband/verbs.h',
> +		'struct ibv_counters_init_attr', 'comp_mask' ],
>  	]
>  	# input array for meson symbol search:
>  	# [ "MACRO to define if found", "header for the search", diff --git
> a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index
> 13f2fd4..bb19085 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -739,7 +739,7 @@
>  	unsigned int mprq_max_stride_size_n = 0;
>  	unsigned int mprq_min_stride_num_n = 0;
>  	unsigned int mprq_max_stride_num_n = 0; -#ifdef
> HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT
> +#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_V42
>  	struct ibv_counter_set_description cs_desc = { .counter_type = 0 };
> #endif
>  	struct ether_addr mac;
> @@ -1009,7 +1009,7 @@
>  	config.hw_csum = !!(attr.device_cap_flags_ex &
> IBV_DEVICE_RAW_IP_CSUM);
>  	DRV_LOG(DEBUG, "checksum offloading is %ssupported",
>  		(config.hw_csum ? "" : "not "));
> -#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT
> +#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_V42
>  	config.flow_counter_en = !!attr.max_counter_sets;
>  	mlx5_glue->describe_counter_set(ctx, 0, &cs_desc);
>  	DRV_LOG(DEBUG, "counter type = %d, num of cs = %ld, attributes =
> %d", diff --git a/drivers/net/mlx5/mlx5_flow_verbs.c
> b/drivers/net/mlx5/mlx5_flow_verbs.c
> index 6ddb13b..3d6fedb 100644
> --- a/drivers/net/mlx5/mlx5_flow_verbs.c
> +++ b/drivers/net/mlx5/mlx5_flow_verbs.c
> @@ -60,7 +60,7 @@
>  		cnt->ref_cnt++;
>  		return cnt;
>  	}
> -#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT
> +#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_V42
> 
>  	struct mlx5_flow_counter tmpl = {
>  		.shared = shared,
> @@ -938,7 +938,7 @@
>  {
>  	const struct rte_flow_action_count *count = action->conf;
>  	struct rte_flow *flow = dev_flow->flow; -#ifdef
> HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT
> +#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_V42
>  	unsigned int size = sizeof(struct ibv_flow_spec_counter_action);
>  	struct ibv_flow_spec_counter_action counter = {
>  		.type = IBV_FLOW_SPEC_ACTION_COUNT,
> @@ -957,7 +957,7 @@
>  						  " context.");
>  	}
>  	*action_flags |= MLX5_FLOW_ACTION_COUNT; -#ifdef
> HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT
> +#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_V42
>  	counter.counter_set_handle = flow->counter->cs->handle;
>  	flow_verbs_spec_add(dev_flow, &counter, size);  #endif @@ -
> 1222,7 +1222,7 @@
>  			detected_actions |= MLX5_FLOW_ACTION_RSS;
>  			break;
>  		case RTE_FLOW_ACTION_TYPE_COUNT:
> -#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT
> +#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_V42
>  			size += sizeof(struct ibv_flow_spec_counter_action);
> #endif
>  			detected_actions |= MLX5_FLOW_ACTION_COUNT;
> @@ -1665,7 +1665,7 @@
>  		       void *data __rte_unused,
>  		       struct rte_flow_error *error)
>  {
> -#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT
> +#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_V42
>  	if (flow->actions & MLX5_FLOW_ACTION_COUNT) {
>  		struct rte_flow_query_count *qc = data;
>  		uint64_t counters[2] = {0, 0};
> diff --git a/drivers/net/mlx5/mlx5_glue.c b/drivers/net/mlx5/mlx5_glue.c
> index 48590df..889e074 100644
> --- a/drivers/net/mlx5/mlx5_glue.c
> +++ b/drivers/net/mlx5/mlx5_glue.c
> @@ -215,7 +215,7 @@
>  mlx5_glue_create_counter_set(struct ibv_context *context,
>  			     struct ibv_counter_set_init_attr *init_attr)  { -
> #ifndef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT
> +#ifndef HAVE_IBV_DEVICE_COUNTERS_SET_V42
>  	(void)context;
>  	(void)init_attr;
>  	return NULL;
> @@ -227,7 +227,7 @@
>  static int
>  mlx5_glue_destroy_counter_set(struct ibv_counter_set *cs)  { -#ifndef
> HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT
> +#ifndef HAVE_IBV_DEVICE_COUNTERS_SET_V42
>  	(void)cs;
>  	return ENOTSUP;
>  #else
> @@ -240,7 +240,7 @@
>  			       uint16_t counter_set_id,
>  			       struct ibv_counter_set_description *cs_desc)  { -
> #ifndef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT
> +#ifndef HAVE_IBV_DEVICE_COUNTERS_SET_V42
>  	(void)context;
>  	(void)counter_set_id;
>  	(void)cs_desc;
> @@ -254,7 +254,7 @@
>  mlx5_glue_query_counter_set(struct ibv_query_counter_set_attr
> *query_attr,
>  			    struct ibv_counter_set_data *cs_data)  { -#ifndef
> HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT
> +#ifndef HAVE_IBV_DEVICE_COUNTERS_SET_V42
>  	(void)query_attr;
>  	(void)cs_data;
>  	return ENOTSUP;
> diff --git a/drivers/net/mlx5/mlx5_glue.h b/drivers/net/mlx5/mlx5_glue.h
> index f6e4e38..adee972 100644
> --- a/drivers/net/mlx5/mlx5_glue.h
> +++ b/drivers/net/mlx5/mlx5_glue.h
> @@ -23,7 +23,7 @@
>  #define MLX5_GLUE_VERSION ""
>  #endif
> 
> -#ifndef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT
> +#ifndef HAVE_IBV_DEVICE_COUNTERS_SET_V42
>  struct ibv_counter_set;
>  struct ibv_counter_set_data;
>  struct ibv_counter_set_description;
> --
> 1.8.3.1