[dpdk-dev] [PATCH v5 0/8] FIPS validation capability
Akhil Goyal
akhil.goyal at nxp.com
Wed Oct 24 13:42:09 CEST 2018
Hi Marko,
On 10/17/2018 6:19 PM, Marko Kovacevic wrote:
> This sample application is made for the purpose so that users of DPDK
> who wish to get FIPS certification for their platforms, this sample app enables
> users to parse test vectors that is gotten from NIST and be able to get
> a generated response file which they can then verify and be sure their
> system will pass FIPS certification.
>
>
> Marko Kovacevic (8):
> v5:
> - Changed patch titles
patch titles are still not correct
> - Added MAINTAINERS File
> - Removed bus_pci Dependency
> - Updated documentation
> - Changed app name
I do not see app name changed? Also there is mismatch in the file name
for doc(.rst file and app name).
I can see that in fips_validation.rst, cryptodev_fips_validate_app is used.
The app name looks pretty long, I suggested for a shorter name like
fips_validation
> v4:
> - Added Limitation
> - Changed TDES BLOCK SIZE from 16 -> 8
> as DES block size is 64bits (main.c)
> v3:
> - Fixed a no-testing bug
> - Fixed some code style issue
>
> v2:
> - Refactor the code.
> - Move the code from test to sample applcation
>
> examples/cryptodev_fips_validate: add fips validation into examples
examples/fips_validation: add cryptodev fips compliant application
> examples/cryptodev_fips_validate: add aes parser and enablement for
> test types
should not this be only examples/fips_validation: support AES parsing
> examples/cryptodev_fips_validate: add hmac parser
examples/fips_validation: support HMAC parsing
> examples/cryptodev_fips_validate: add TDES parser and enablement for
> test types
same for this one -- examples/fips_validation: support TDES parsing
> examples/cryptodev_fips_validate: add gcm parser
examples/cryptodev_fips_validate: support GCM parsing
> examples/cryptodev_fips_validate: add cmac parser and enablement for
> test types
examples/fips_validation: support CMAC parsing
> examples/cryptodev_fips_validate: add ccm parser and enablement for
> test types
examples/fips_validation: support CCM parsing
> doc/guides/sample_app_ug: add guides for fips validation
doc: add fips validation application guide
>
> MAINTAINERS | 4 +
MAINTAINERS changes shall be split in 2 patches. for
examples/fips_validation add in 1/8 and for rst file 8/8
> doc/guides/rel_notes/release_18_11.rst | 6 +
> doc/guides/sample_app_ug/fips_validation.rst | 119 ++
> doc/guides/sample_app_ug/index.rst | 1 +
> examples/cryptodev_fips_validate/Makefile | 75 ++
> .../cryptodev_fips_parse_3des.c | 259 +++++
> .../cryptodev_fips_parse_aes.c | 188 +++
> .../cryptodev_fips_parse_ccm.c | 272 +++++
> .../cryptodev_fips_parse_cmac.c | 116 ++
> .../cryptodev_fips_parse_gcm.c | 125 ++
> .../cryptodev_fips_parse_hmac.c | 105 ++
> .../cryptodev_fips_parse_validate.c | 593 ++++++++++
> .../cryptodev_fips_validate.h | 234 ++++
> examples/cryptodev_fips_validate/main.c | 1221 ++++++++++++++++++++
> examples/cryptodev_fips_validate/meson.build | 20 +
> 15 files changed, 3338 insertions(+)
> create mode 100644 doc/guides/sample_app_ug/fips_validation.rst
> create mode 100644 examples/cryptodev_fips_validate/Makefile
> create mode 100644 examples/cryptodev_fips_validate/cryptodev_fips_parse_3des.c
> create mode 100644 examples/cryptodev_fips_validate/cryptodev_fips_parse_aes.c
> create mode 100644 examples/cryptodev_fips_validate/cryptodev_fips_parse_ccm.c
> create mode 100644 examples/cryptodev_fips_validate/cryptodev_fips_parse_cmac.c
> create mode 100644 examples/cryptodev_fips_validate/cryptodev_fips_parse_gcm.c
> create mode 100644 examples/cryptodev_fips_validate/cryptodev_fips_parse_hmac.c
> create mode 100644 examples/cryptodev_fips_validate/cryptodev_fips_parse_validate.c
> create mode 100644 examples/cryptodev_fips_validate/cryptodev_fips_validate.h
> create mode 100644 examples/cryptodev_fips_validate/main.c
> create mode 100644 examples/cryptodev_fips_validate/meson.build
>
More information about the dev
mailing list