[dpdk-dev] [PATCH v8 05/13] telemetry: add client feature and sockets

[Richardson, Bruce]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Thursday, October 25, 2018 9:50 PM
> To: Richardson, Bruce <bruce.richardson at intel.com>
> Cc: Laatz, Kevin <kevin.laatz at intel.com>; dev at dpdk.org; Van Haaren, Harry
> <harry.van.haaren at intel.com>; stephen at networkplumber.org;
> gaetan.rivet at 6wind.com; shreyansh.jain at nxp.com;
> mattias.ronnblom at ericsson.com; Ciara Power <ciara.power at intel.com>; Brian
> Archbold <brian.archbold at intel.com>
> Subject: Re: [dpdk-dev] [PATCH v8 05/13] telemetry: add client feature and
> sockets
> 
> 25/10/2018 22:44, Bruce Richardson:
> > On Thu, Oct 25, 2018 at 10:41:53PM +0200, Thomas Monjalon wrote:
> > > 25/10/2018 22:29, Thomas Monjalon:
> > > > 24/10/2018 18:03, Kevin Laatz:
> > > > > --- a/lib/librte_telemetry/meson.build
> > > > > +++ b/lib/librte_telemetry/meson.build
> > > > > @@ -5,3 +5,5 @@ sources = files('rte_telemetry.c')  headers =
> > > > > files('rte_telemetry.h', 'rte_telemetry_internal.h')  deps +=
> > > > > ['metrics', 'ethdev']  cflags += '-DALLOW_EXPERIMENTAL_API'
> > > > > +jansson = cc.find_library('jansson', required: true) ext_deps
> > > > > ++= jansson
> > > >
> > > > I just discovered an issue when trying to compile for arm64 (with
> > > > devtools/test-meson-builds.sh):
> > > >
> > > > /usr/lib/gcc/aarch64-linux-gnu/8.2.0/../../../../aarch64-linux-
> gnu/bin/ld:
> > > > 	cannot find -ljansson
> > > >
> > > > I am worried because it is a real blocker.
> > >
> > > The dependency must be optional.
> > > Should we disable the library if jansson is not found?
> > >
> > Yes, it should be.
> >
> > Needs:
> >
> > 	jansson = cc.find_library('jansson', required: false)
> > 	build = jansson.found()
> 
> And for the makefile?
> 
> It has been introduced (too early) in patch 3:
> 	LDLIBS += -ljansson
> I think we must use pkg-config to check if jansson is found.
> 

I didn't look at the makefile, because you never asked! :-)