[dpdk-dev] [PATCH 1/2] ring: synchronize the load and store of the tail
jerin.jacob at caviumnetworks.com
Sat Oct 27 17:34:07 CEST 2018
> Date: Sat, 27 Oct 2018 17:13:10 +0200
> From: Thomas Monjalon <thomas at monjalon.net>
> To: Jerin Jacob <jerin.jacob at caviumnetworks.com>
> Cc: "Gavin Hu (Arm Technology China)" <Gavin.Hu at arm.com>, "dev at dpdk.org"
> <dev at dpdk.org>, Honnappa Nagarahalli <Honnappa.Nagarahalli at arm.com>,
> "stable at dpdk.org" <stable at dpdk.org>, Ola Liljedahl
> <Ola.Liljedahl at arm.com>, "olivier.matz at 6wind.com"
> <olivier.matz at 6wind.com>, "chaozhu at linux.vnet.ibm.com"
> <chaozhu at linux.vnet.ibm.com>, "bruce.richardson at intel.com"
> <bruce.richardson at intel.com>, "konstantin.ananyev at intel.com"
> <konstantin.ananyev at intel.com>
> Subject: Re: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and store of
> the tail
> 27/10/2018 17:00, Jerin Jacob:
> > From: Thomas Monjalon <thomas at monjalon.net>
> > > 17/10/2018 08:35, Gavin Hu (Arm Technology China):
> > > > Hi Jerin
> > > >
> > > > As the 1st one of the 3-patch set was not concluded, I submit this 2-patch series to unblock the merge.
> > >
> > > The thread is totally messed up because:
> > > - there is no cover letter
> > > - some different series (testpmd, i40e and doc) are in the same thread
> > > - v4 replies to a different series
> > > - this version should be a v5 but has no number
> > > - this version replies to the v3
> > > - patchwork still shows v3 and "v5"
> > > - replies from Ola are not quoting previous discussion
> > >
> > > Because of all of this, it is really difficult to follow.
> > > This is probably the reason of the lack of review outside of Arm.
> > >
> > > One more issue: you must Cc the relevant maintainers.
> > > Here:
> > > - Olivier for rte_ring
> > > - Chao for IBM platform
> > > - Bruce and Konstantin for x86
> > >
> > > Guys, it is really cool to have more Arm developpers in DPDK.
> > > But please consider better formatting your discussions, it is really
> > > important in our contribution workflow.
> > >
> > > I don't know what to do.
> > > I suggest to wait for more feedbacks and integrate it in -rc2.
> > This series has been acked and tested. Sure, if we are looking for some
> > more feedback we can push to -rc2 if not it a good candidate to be
> > selected for -rc1.
> It has been acked and tested only for Arm platforms.
> And Olivier, the ring maintainer, was not Cc.
> I feel it is not enough.
Sure, More reviews is already better. But lets keep as -rc2 target.
More information about the dev