[dpdk-dev] [PATCH v2 6/9] app/procinfo: add code for debug crypto
vipin.varghese at intel.com
Mon Oct 29 15:29:19 CET 2018
> > > This is a very big macro, better have static function for this instead of
> > >
> > There are two thoughts in choosing MACRO over function.
> > 1. The information need to display in certain format within the same context.
> > 2. As the API are modified, co locating all at same scope is easier to clean up
> and correct in future.
> > So I feel use of MACRO over function in this instance.
> I don't agree with your arguments. Macros, are ugly and error prone. This is
> not performance critical so it should be a function. The only reason to use
> macro's is if it is not possible to write it as a function (as in a template for code
Thanks for the sharing your feedback. But In my comments I never stated the MACRO were used for performance or critical blocks. As mentioned in my explanation, the MACRO is used for printing the desired format and format the code.
Since I have received 2 request for change, I will do the same and release v3.
More information about the dev