[dpdk-dev] [PATCH 14/15] net/vmxnet3: rename version map after library file name

Thomas Monjalon thomas at monjalon.net
Fri Sep 14 09:46:43 CEST 2018


13/09/2018 23:44, Yong Wang:
> From: Luca Boccassi <bluca at debian.org>
>     The library is called librte_pmd_vmxnet3_uio, so rename the map
>     file and set the name in the meson file so that the built library names
>     with meson and legacy makefiles are the same
>     
>     Signed-off-by: Luca Boccassi <bluca at debian.org>
>     ---
> 
> Not directly related to this change but I have some question on the uio naming.  The original motivation is from the following commit:
> 
> commit 1daf0aae7fd6b3bc38952e9817a1653c1258be66
> Author: Thomas Monjalon <thomas.monjalon at 6wind.com>
> Date:   Fri Mar 21 13:52:17 2014 +0100
> 
>     vmxnet3: rename library
>     
>     In order to distinguish clearly this implementation from the extension
>     vmxnet3-usermap, it is renamed to reflect its usage of uio framework.
>     
>     Signed-off-by: Thomas Monjalon <thomas.monjalon at 6wind.com>
>     Acked-by: Thomas Graf <tgraf at redhat.com>
> 
> However, this version of vmxnet3 can also be bound to vfio-pci driver.  I think having the uio naming in that case will be misleading. 

Yes, i agree.
vmxnet3-usermap is not maintained anymore, so we can remove the uio suffix.





More information about the dev mailing list