[dpdk-dev] [PATCH v3 2/3] net/i40e: remove invalid comment

Gavin Hu (Arm Technology China) Gavin.Hu at arm.com
Mon Sep 17 10:25:11 CEST 2018


Hi All,

I am really sorry I made a mistake by submitting patches from a wrong branch and tried to rescue quickly and made another mistake(submitted one more patch not mine).

Please skip these wrong patches(I already superseded them) and help review the new 3 patches for rte ring.

Really sorry again for the confusion and inconveniences!

Best Regards,
Gavin

> -----Original Message-----
> From: Gavin Hu <gavin.hu at arm.com>
> Sent: Monday, September 17, 2018 3:48 PM
> To: dev at dpdk.org
> Cc: Gavin Hu (Arm Technology China) <Gavin.Hu at arm.com>; Honnappa
> Nagarahalli <Honnappa.Nagarahalli at arm.com>; Steve Capper
> <Steve.Capper at arm.com>; Ola Liljedahl <Ola.Liljedahl at arm.com>;
> jerin.jacob at caviumnetworks.com; nd <nd at arm.com>; Ferruh Yigit
> <ferruh.yigit at intel.com>
> Subject: [PATCH v3 2/3] net/i40e: remove invalid comment
> 
> From: Ferruh Yigit <ferruh.yigit at intel.com>
> 
> Comments says "no csum error report support" but there is no check related
> csum offloads. Removing the comment.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> Acked-by: Qi Zhang <qi.z.zhang at intel.com>
> ---
>  drivers/net/i40e/i40e_rxtx_vec_common.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h
> b/drivers/net/i40e/i40e_rxtx_vec_common.h
> index 63cb17742..f00f6d648 100644
> --- a/drivers/net/i40e/i40e_rxtx_vec_common.h
> +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
> @@ -199,9 +199,7 @@
> i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev)
>  	if (fconf->mode != RTE_FDIR_MODE_NONE)
>  		return -1;
> 
> -	 /* - no csum error report support
> -	 * - no header split support
> -	 */
> +	 /* no header split support */
>  	if (rxmode->offloads & DEV_RX_OFFLOAD_HEADER_SPLIT)
>  		return -1;
> 
> --
> 2.11.0



More information about the dev mailing list