[dpdk-dev] [PATCH] event/sw: fix cq idx check for unlink usecases

Elo, Matias (Nokia - FI/Espoo) matias.elo at nokia.com
Fri Sep 21 14:17:38 CEST 2018



> On 21 Sep 2018, at 13:25, Harry van Haaren <harry.van.haaren at intel.com> wrote:
> 
> This commit fixes the cq index checks when unlinking
> ports/queues while the scheduler core is running.
> Previously, the == comparison could be "skipped" if
> in particular corner cases. With the check being changed
> to >= this is resolved as the cq idx gets reset to zero.
> 
> Bugzilla ID: 60
> Fixes: 617995dfc5b2 ("event/sw: add scheduling logic")
> 
> Suggested-by: Matias Elo <matias.elo at nokia.com>
> Signed-off-by: Harry van Haaren <harry.van.haaren at intel.com>
> 
> ---
> 
> Cc: stable at dpdk.org
> 
> @Matias,
> 
> When testing this patch with your provided test case as per attachment
> to bug #60 in Bugzilla, I don't see any events arriving to port 0.
> Hence, I believe this to be the correct behaviour, if you can confirm
> that'd be awesome!
> 

I can confirm that this patch fixes the problem also on my system. Thanks!

I can’t remember if I ever saw this problem with ordered queues. At least now they seem to be also working correctly.

Regards,
Matias



More information about the dev mailing list