[dpdk-dev] [PATCH] test/eventdev: fix incorrect unit test
Jerin Jacob
jerin.jacob at caviumnetworks.com
Sun Sep 23 10:59:07 CEST 2018
-----Original Message-----
> Date: Wed, 5 Sep 2018 19:53:31 +0530
> From: Pavan Nikhilesh <pbhagavatula at caviumnetworks.com>
> To: jerin.jacob at caviumnetworks.com
> Cc: dev at dpdk.org, Pavan Nikhilesh <pbhagavatula at caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH] test/eventdev: fix incorrect unit test
> X-Mailer: git-send-email 2.18.0
>
> Enqueue, dequeue depths are only valid for event devs that have burst
> mode capability. Check event dev capability before testing depth
> boundary.
>
> Fixes: f8f9d233ea0e ("test/eventdev: add unit tests")
Cc: stable at dpdk.org
Acked-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula at caviumnetworks.com>
> ---
> test/test/test_eventdev.c | 21 ++++++++++++---------
> 1 file changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/test/test/test_eventdev.c b/test/test/test_eventdev.c
> index 04bdc6b6c..00d73275c 100644
> --- a/test/test/test_eventdev.c
> +++ b/test/test/test_eventdev.c
> @@ -190,15 +190,18 @@ test_eventdev_configure(void)
> "Config negative test failed");
> TEST_ASSERT_EQUAL(-EINVAL,
> test_ethdev_config_run(&dev_conf, &info, max_event_queue_flows),
> - "Config negative test failed");
> - TEST_ASSERT_EQUAL(-EINVAL,
> - test_ethdev_config_run(&dev_conf, &info,
> - max_event_port_dequeue_depth),
> - "Config negative test failed");
> - TEST_ASSERT_EQUAL(-EINVAL,
> - test_ethdev_config_run(&dev_conf, &info,
> - max_event_port_enqueue_depth),
> - "Config negative test failed");
> + "Config negative test failed");
> +
> + if (info.event_dev_cap & RTE_EVENT_DEV_CAP_BURST_MODE) {
> + TEST_ASSERT_EQUAL(-EINVAL,
> + test_ethdev_config_run(&dev_conf, &info,
> + max_event_port_dequeue_depth),
> + "Config negative test failed");
> + TEST_ASSERT_EQUAL(-EINVAL,
> + test_ethdev_config_run(&dev_conf, &info,
> + max_event_port_enqueue_depth),
> + "Config negative test failed");
> + }
>
> /* Positive case */
> devconf_set_default_sane_values(&dev_conf, &info);
> --
> 2.18.0
>
More information about the dev
mailing list