[dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready

Wang, Xiao W xiao.w.wang at intel.com
Wed Sep 26 02:12:40 CEST 2018


Hi,

> -----Original Message-----
> From: Kevin Traynor [mailto:ktraynor at redhat.com]
> Sent: Wednesday, September 26, 2018 1:16 AM
> To: Wang, Xiao W <xiao.w.wang at intel.com>
> Cc: Ye, Xiaolong <xiaolong.ye at intel.com>; Bie, Tiwei <tiwei.bie at intel.com>;
> dev at dpdk.org; stable at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready
> 
> On 09/14/2018 02:25 AM, Xiao Wang wrote:
> > If the device is not clearly reset by the previous driver and holds
> > some invalid ring addr, and the relay thread kicks it before HW is
> > properly re-configured, a bad DMA request may happen.
> >
> > Besides, the notify_addr which is used by the relay thread is set in
> > the vdpa_ifcvf_start function, if a kick relay happens before
> > vdpa_ifcvf_start finishes, a null addr is accessed.
> >
> > Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
> >
> 
> Looks like this should be in stable branch too. Can you confirm?	

Yes, they should go also into stable branch, thanks for the notice.

BRs,
Xiao


More information about the dev mailing list