[dpdk-dev] [PATCH v1 5/5] vfio: enable vfio hotplug by req notifier handler

[Burakov, Anatoly]

On 17-Aug-18 11:51 AM, Jeff Guo wrote:
> This patch will add req notifier processing to enable hotplug for vfio.
> When device is be hotplug-out, the vfio kernel module will sent req
> notifier to request user space to release the allocated resources. It
> could use the bus failure mechanism to trigger the currently hotplug
> procedure of user space. After that, vfio kernel module will detect the
> device disappear, and then release the kernel resource of the device.
> 
> Signed-off-by: Jeff Guo <jia.guo at intel.com>
> ---

<snip>

> +	 * resources before resources be released in kernel, so it can directly
> +	 * call the bus failure handler to use the specific mechanism in
> +	 * user space to handle it.
> +	 */
> +	ret = bus->memory_failure_handler(device);
> +	if (ret) {
> +		RTE_LOG(ERR, EAL, "Can not handle failure for "
> +			"device (%s)\n", device->name);
> +		return;

Return is not needed here :)

Otherwise, LGTM

-- 
Thanks,
Anatoly