[dpdk-dev] [PATCH v6 2/2] examples/vdpa: introduce a new sample for vDPA

Ye Xiaolong xiaolong.ye at intel.com
Fri Sep 28 09:32:21 CEST 2018


On 09/27, Maxime Coquelin wrote:
[snip]
>> +	devcnt = 0;
>This isn't needed as it is static.
>
>> +	interactive = 0;
>Ditto
>
>> +	memset(iface, 0, sizeof(iface));
>Ditto
>
>> +	memset(vports, 0, sizeof(vports));
>And this one too when it will be made static.
>
>
>Appart these small comments, it looks good to me.
>When fixed, please apply my:
>
>Reviewed-by: Maxime coquelin <maxime.coquelin at redhat.com>
>

Thanks for your comments, I'll adpot all the static related suggetions.

Thanks,
Xiaolong
>Thanks,
>Maxime


More information about the dev mailing list