[dpdk-dev] [PATCH v7 2/2] examples/vdpa: introduce a new sample for vDPA

Maxime Coquelin maxime.coquelin at redhat.com
Fri Sep 28 09:49:41 CEST 2018



On 09/28/2018 04:33 PM, Ye Xiaolong wrote:
> On 09/28, Maxime Coquelin wrote:
>>> +	ret = rte_eal_init(argc, argv);
>>> +	if (ret < 0)
>>> +		rte_exit(EXIT_FAILURE, "eal init failed\n");
>>> +	argc -= ret;
>>> +	argv += ret;
>>> +
>>> +	data_init();
>>
>> You need to check return from data_init().
>> If this is fine for you, I can change to below code when applying:
>>
>> ret = data_init();
>> if (ret < 0)
>>     rte_exit(EXIT_FAILURE, "data init failed\n");
>>
>>
> 
> I'm fine with this change.

Or even better, get rid of data_init and
call rte_vdpa_get_device_num(); in main directly.

> Thanks,
> Xiaolong
> 


More information about the dev mailing list