[dpdk-dev] [PATCH v2] net/i40e: select fdir config automatically

[Li, Xiaoyun]

> -----Original Message-----
> From: Xing, Beilei
> Sent: Saturday, September 29, 2018 16:37
> To: Li, Xiaoyun <xiaoyun.li at intel.com>; Zhang, Qi Z <qi.z.zhang at intel.com>;
> Yigit, Ferruh <ferruh.yigit at intel.com>
> Cc: dev at dpdk.org
> Subject: RE: [PATCH v2] net/i40e: select fdir config automatically
> 
> 
> 
> > -----Original Message-----
> > From: Li, Xiaoyun
> > Sent: Friday, September 28, 2018 7:03 PM
> > To: Xing, Beilei <beilei.xing at intel.com>; Zhang, Qi Z
> > <qi.z.zhang at intel.com>; Yigit, Ferruh <ferruh.yigit at intel.com>
> > Cc: dev at dpdk.org; Li, Xiaoyun <xiaoyun.li at intel.com>
> > Subject: [PATCH v2] net/i40e: select fdir config automatically
> >
> > I40e driver needed users to config exact fdir mode to create rte_flow
> > rules but it shouldn't. This patch allows users to create rte_flow
> > rules without configuring fdir mode and let the driver select the
> > config automatically. And remove the workaround in flow_filtering
> example.
> >
> > Signed-off-by: Xiaoyun Li <xiaoyun.li at intel.com>
> > ---
> > v2:
> >  * Added fdir teardown in i40e_flow_flush_fdir_filter.
> >  * Replace TAILQ_FIRST with TAILQ_EMPTY which is more intuitive.
> >  * Remove the workaround in flow_filtering example since the driver
> > will
> >  * set the fdir config automatically.
> > +
> > +		/* If the last flow is destroyed, disable fdir. */
> > +		if (!ret && !TAILQ_EMPTY(&pf->fdir.fdir_list)) {
> 
> Should be if (!ret && TAILQ_EMPTY(&pf->fdir.fdir_list)) here?

Yes. Sorry about that. Will correct it.

> 
> > --
> > 2.17.1