[dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 adapters

Stephen Hemminger stephen at networkplumber.org
Thu Aug 1 00:55:42 CEST 2019


On Wed, 31 Jul 2019 17:41:11 -0500
David Christensen <drc at linux.vnet.ibm.com> wrote:

> The function mlx5_set_min_inline() includes a switch() that checks
> various PCI device IDs in order to set the txq_inline_min value.  No
> value is set when the PCI device ID matches the ConnectX-5 adapters,
> resulting in an assert() failure later in the function
> mlx5_set_txlimit_params().
> 
> This error was encountered on an IBM Power 9 system running RHEL 7.6
> w/o Mellanox OFED installed.
> 
> Fixes: 38b4b397a57d ("net/mlx5: add Tx configuration and setup")
> Cc: viacheslavo at mellanox.com
> 
> Signed-off-by: David Christensen <drc at linux.vnet.ibm.com>
> ---
>  drivers/net/mlx5/mlx5.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> index 3a345c7..0f61dd5 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -1341,6 +1341,7 @@ struct mlx5_dev_spawn_data {
>  		 * and PFC control may be broken, so disable feature.
>  		 */
>  		config->hw_vlan_insert = 0;
> +		config->txq_inline_min = MLX5_INLINE_HSIZE_NONE;
>  		break;
>  	default:
>  		config->txq_inline_min = MLX5_INLINE_HSIZE_NONE;

This is a case where a simple switch fallthrough would have same effect.


More information about the dev mailing list