[dpdk-dev] [PATCH] net/mlx5: fix redundant use of directive

Raslan Darawsheh rasland at mellanox.com
Mon Aug 5 14:59:20 CEST 2019


Hi,

> -----Original Message-----
> From: dev <dev-bounces at dpdk.org> On Behalf Of Dekel Peled
> Sent: Monday, August 5, 2019 10:07 AM
> To: Yongseok Koh <yskoh at mellanox.com>; Slava Ovsiienko
> <viacheslavo at mellanox.com>; Shahaf Shuler <shahafs at mellanox.com>
> Cc: Ori Kam <orika at mellanox.com>; dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix redundant use of directive
> 
> Part of the code in function flow_dv_matcher_enable() is enclosed in '#ifdef
> HAVE_MLX5DV_DR' preprocessor directive.
> Using this directive is not needed here, and prevents compilation of relevant
> code.
> 
> This patch removes the redundant preprocessor directive.
> 
> Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API")
> 
> Signed-off-by: Dekel Peled <dekelp at mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_flow_dv.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c index 9c0a261..582f644 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -4324,11 +4324,9 @@ struct field_modify_info modify_tcp[] = {
>  	match_criteria_enable |=
>  		(!HEADER_IS_ZERO(match_criteria, misc_parameters_2)) <<
>  		MLX5_MATCH_CRITERIA_ENABLE_MISC2_BIT;
> -#ifdef HAVE_MLX5DV_DR
>  	match_criteria_enable |=
>  		(!HEADER_IS_ZERO(match_criteria, misc_parameters_3)) <<
>  		MLX5_MATCH_CRITERIA_ENABLE_MISC3_BIT;
> -#endif
>  	return match_criteria_enable;
>  }
> 
> --
> 1.8.3.1

Patch applied to next-net-mlx,

Kindest regards
Raslan Darawsheh


More information about the dev mailing list