[dpdk-dev] [PATCH v3 1/1] common/octeontx2: fix unaligned mbox memory accesses

Thomas Monjalon thomas at monjalon.net
Mon Aug 5 23:22:07 CEST 2019


02/08/2019 11:55, Jerin Jacob Kollanukkaran:
> > From: Vamsi Attunuru <vattunuru at marvell.com>
> > 
> > Octeontx2 PMD's mailbox client uses device memory to send messages to
> > mailbox server in the admin function Linux kernel driver.
> > The device memory used for the mailbox communication needs to be
> > qualified as volatile memory type to avoid unaligned device memory
> > accesses because of compiler's memory access coalescing.
> > 
> > This patch modifies the mailbox request and responses as volatile type which
> > were non-volatile earlier and accessed from unaligned memory addresses
> > which resulted in bus errors on Fedora 30 with gcc 9.1.1.
> > 
> > Fixes: 2b71657c8660 ("common/octeontx2: add mbox request and response
> > definition")
> > 
> > Signed-off-by: Vamsi Attunuru <vattunuru at marvell.com>
> > Signed-off-by: Nithin Dabilpuram <ndabilpuram at marvell.com>
> 
> Acked-by: Jerin Jacob <jerinj at marvell.com>
> 
> Thomas,
> 
> Could you merge this patch for rc4. It fixes the bus error with  Fedora 30 with gcc 9.1.1.

Applied, thanks





More information about the dev mailing list