[dpdk-dev] [PATCH] examples/ntb: fix resource leaks

Xiaoyun Li xiaoyun.li at intel.com
Wed Aug 14 08:07:25 CEST 2019


Resource file was not freed or pointed-to in fseek/ftell. This patch
fixed this issue which is found by coverity scan.

Coverity issue: 347277
Fixes: 440af660ff83 ("examples/ntb: fix error handling")
Cc: stable at dpdk.org

Signed-off-by: Xiaoyun Li <xiaoyun.li at intel.com>
---
 examples/ntb/ntb_fwd.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c
index f8c970cdb..bf8a73547 100644
--- a/examples/ntb/ntb_fwd.c
+++ b/examples/ntb/ntb_fwd.c
@@ -127,11 +127,13 @@ cmd_sendfile_parsed(void *parsed_result,
 
 	if (fseek(file, 0, SEEK_END) < 0) {
 		printf("Fail to get file size.\n");
+		fclose(file);
 		return;
 	}
 	size = ftell(file);
 	if (fseek(file, 0, SEEK_SET) < 0) {
 		printf("Fail to get file size.\n");
+		fclose(file);
 		return;
 	}
 
-- 
2.17.1



More information about the dev mailing list