[dpdk-dev] [PATCH 4/7] net: update Rx RSS hash offload capabilities

Andrew Rybchenko arybchenko at solarflare.com
Fri Aug 16 09:49:06 CEST 2019


Prefix "net: " is typically used for lib/librte_net. It should be 
"drivers/net: " here.

On 8/16/19 8:55 AM, pbhagavatula at marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavatula at marvell.com>
>
> Add DEV_RX_OFFLOAD_RSS_HASH flag for all supported NICs.

"all supported NICs" sounds wrong here.  I'd say
"all PMDs which support RSS hash delivery" or something like this.

> Signed-off-by: Pavan Nikhilesh <pbhagavatula at marvell.com>
> ---

[snip]

> diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c
> index e6809bb64..695580b22 100644
> --- a/drivers/net/sfc/sfc_rx.c
> +++ b/drivers/net/sfc/sfc_rx.c
> @@ -618,7 +618,8 @@ struct sfc_dp_rx sfc_efx_rx = {
>   	},
>   	.features		= SFC_DP_RX_FEAT_INTR,
>   	.dev_offload_capa	= DEV_RX_OFFLOAD_CHECKSUM,
> -	.queue_offload_capa	= DEV_RX_OFFLOAD_SCATTER,
> +	.queue_offload_capa	= DEV_RX_OFFLOAD_SCATTER |
> +				  DEV_RX_OFFLOAD_RSS_HASH,
>   	.qsize_up_rings		= sfc_efx_rx_qsize_up_rings,
>   	.qcreate		= sfc_efx_rx_qcreate,
>   	.qdestroy		= sfc_efx_rx_qdestroy,
>

Similar changes are required in sfc_ef10_essb_rx
(drivers/net/sfc/sfc_ef10_essb_rx.c) and sfc_ef10_rx
(drivers/net/sfc/sfc_ef10_rx.c).



More information about the dev mailing list