[dpdk-dev] [PATCH v4] timer: don't check tsc flags in secondary processes

Stephen Hemminger stephen at networkplumber.org
Mon Aug 19 19:10:02 CEST 2019


On Mon, 19 Aug 2019 02:42:10 -0700
Jim Harris <james.r.harris at intel.com> wrote:

> check_tsc_flags() parses /proc/cpuinfo and prints
> warning messages if any cores don't have constant_tsc
> and nonstop_tsc.  It has no functional meaning.
> This consumes a noticeable amount of time in
> secondary processes - on my test system, it consumes
> 21ms out of the 66ms total execution time for
> rte_eal_init().
> 
> So let's just skip checking these flags in secondary
> processes.  Since the primary process is already
> parsing the entirety of /proc/cpuinfo, the warning
> printed in the primary process should be sufficient.
> 
> Signed-off-by: Jim Harris <james.r.harris at intel.com>

Since all it does is print a warning, I would argue the code is useless
anyway and should just be removed. The warning doesn't provide any 
indication of what to do for users; or even tell them what the effect is.


More information about the dev mailing list