[dpdk-dev] [PATCH 00/51] ethdev: change rte_eth_dev_info_get() return value to int

Andrew Rybchenko arybchenko at solarflare.com
Wed Aug 28 09:02:26 CEST 2019


On 8/27/19 11:47 PM, Aaron Conole wrote:
> Andrew Rybchenko <arybchenko at solarflare.com> writes:
>
>> It is the first patch series to get rid of void returning functions
>> in ethdev in accordance with deprecation notice [1].
> This is a huge series, and I suggest to combine some of the work, and/or
> break it up.

I can send patches for examples separately, but it will not help a lot.
I can squash changes in examples, but I think it is wrong since it would
make review harder - different maintainers and different practices to
handle error in different examples (and we tried to take it into account).

Other ideas?

> Additionally, this patch breaks the ring_pmd_autotest unit test, but I
> didn't bisect it to find out where.

Many thanks, we'll take a look.



More information about the dev mailing list