[dpdk-dev] [PATCH 10/22] net/hns3: add support for RSS of hns3 PMD driver

Wei Hu (Xavier) xavier.huwei at huawei.com
Sat Aug 31 11:16:52 CEST 2019


Hi, Ferruh Yigit


On 2019/8/30 23:07, Ferruh Yigit wrote:
> On 8/23/2019 2:46 PM, Wei Hu (Xavier) wrote:
>> This patch adds support for RSS of hns3 PMD driver.
>> It included the following functions in file hns3_rss.c:
>> 1) Set/query hash key, rss_hf by .rss_hash_update/.rss_hash_conf_get ops
>>    callback functions.
>> 2) Set/query redirection table by .reta_update/.reta_query. ops callback
>>    functions.
>> 3) Set/query hash algorithm by .filter_ctrl ops callback function when
>>    the 'filter_type' is RTE_ETH_FILTER_HASH.
> Legacy filter API is deprecated, there is a recent patch from Thomas to
> deprecate documenting this as feature:
> Commit 030febb6642c ("doc: remove deprecated ethdev features")
We will remove some related feature, and send patch V2.
Thanks
>> And it included the following functions in file hns3_flow.c:
>> 1) Set hash key, rss_hf, redirection table and algorithm by .create ops
>>    callback function.
>> 2) Disable RSS by .destroy or .flush ops callback function.
>> 3) Check the effectiveness of the RSS's configuration by .validate ops
>>    callback function.
>>
>> Signed-off-by: Hao Chen <chenhao164 at huawei.com>
>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei at huawei.com>
>> Signed-off-by: Chunsong Feng <fengchunsong at huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
>> Signed-off-by: Huisong Li <lihuisong at huawei.com>
> <...>
>
>> @@ -2744,6 +2748,10 @@ static const struct eth_dev_ops hns3_eth_dev_ops = {
>>  	.mac_addr_set           = hns3_set_default_mac_addr,
>>  	.set_mc_addr_list       = hns3_set_mc_mac_addr_list,
>>  	.link_update            = hns3_dev_link_update,
>> +	.rss_hash_update        = hns3_dev_rss_hash_update,
>> +	.rss_hash_conf_get      = hns3_dev_rss_hash_conf_get,
>> +	.reta_update            = hns3_dev_rss_reta_update,
>> +	.reta_query             = hns3_dev_rss_reta_query,
> Can you please update .ini file in this patch and mark following features as
> supported:
> RSS key update
> RSS reta update
>
> For 'RSS hash' datapath update is also required, I am not sure in which patch
> that support it added.
>
OK, will fix it in patch V2.

    Regards
Xavier




More information about the dev mailing list