[dpdk-dev] [PATCH] net/i40e: Add new customized pctype for l2tpv3

[Sexton, Rory]

Hi Beilei,

See below,

Rory

> > > > +/* A structure used to define the input for L2TPv3 flow */ struct 
> > > > +i40e_l2tpv3_flow {
> > >
> > > Seems missed struct rte_eth_ipv4_flow or struct rte_eth_ipv6_flow here?
> > >
> > 
> > I'm not convinced we need struct rte_eth_ipv4_flow or struct 
> > rte_eth_ipv6_flow to be part of the struct i40e_l2tpv3_flow.
> > The rte_eth_ipv4/6_flow struct will be included in the flow director 
> > pattern from the following additions.
> > Please advice so I can update in a v2 of the patch if required.
>
> Please refer to union i40e_fdir_flow: A union contains the inputs for all types of flow items in flows need to be in big endian.
> Pattern is part of rte flow, but not the packet sent to HW to create/destroy a FDIR rule.
>
> Beilei

Ok, I follow you now. Thanks for clarification.
Please see updates in v2.