[dpdk-dev] [PATCH] kni: fix sprintf with snprintf

[Wiles, Keith]

> On Feb 7, 2019, at 10:40 AM, Ferruh Yigit <ferruh.yigit at intel.com> wrote:
> 
> On 2/4/2019 7:02 AM, Pallantla Poornima wrote:
>> sprintf function is not secure as it doesn't check the length of string.
>> More secure function snprintf is used.
>> 
>> Fixes: 3fc5ca2f63 ("kni: initial import")
>> Fixes: b9ee370557 ("kni: update kernel driver ethtool baseline")
>> Cc: stable at dpdk.org
>> 
>> Signed-off-by: Pallantla Poornima <pallantlax.poornima at intel.com>
>> ---
>> kernel/linux/kni/ethtool/igb/igb_ethtool.c    | 41 +++++++++++--------
>> kernel/linux/kni/ethtool/igb/igb_main.c       | 12 ++++--
>> .../linux/kni/ethtool/ixgbe/ixgbe_ethtool.c   | 30 ++++++++------
> 
> Overall updates looks good, but I am not sure if we need to update the kernel
> drivers in KNI. At least *_ethtool.c ones shouldn't be called at all.
> 
> Any objection to skip these files from this patch?

yes, would skip the kernel modules.

Regards,
Keith